From 8a789db9e84c14728bb9bfe9b8a56628b09f8d7b Mon Sep 17 00:00:00 2001
From: Otavio Macedo <288203+otaviomacedo@users.noreply.github.com>
Date: Tue, 2 May 2023 13:41:11 +0100
Subject: [PATCH] fix(core): output folder checksum is computed unnecessarily

---
 .../aws-cdk-lib/core/lib/private/synthesis.ts | 26 ++++++-------------
 .../aws-cdk-lib/core/test/synthesis.test.ts   | 11 ++++++++
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/packages/aws-cdk-lib/core/lib/private/synthesis.ts b/packages/aws-cdk-lib/core/lib/private/synthesis.ts
index 386ad8d0b583e..8f4e00383a18e 100644
--- a/packages/aws-cdk-lib/core/lib/private/synthesis.ts
+++ b/packages/aws-cdk-lib/core/lib/private/synthesis.ts
@@ -1,4 +1,3 @@
-import { createHash } from 'crypto';
 import * as fs from 'fs';
 import * as path from 'path';
 import * as cxapi from '../../../cx-api';
@@ -16,6 +15,7 @@ import { Stage, StageSynthesisOptions } from '../stage';
 import { IPolicyValidationPluginBeta1 } from '../validation';
 import { ConstructTree } from '../validation/private/construct-tree';
 import { PolicyValidationReportFormatter, NamedValidationPluginReport } from '../validation/private/report';
+import { FileSystem } from '../fs';
 
 const POLICY_VALIDATION_FILE_PATH = 'policy-validation-report.json';
 const VALIDATION_REPORT_JSON_CONTEXT = '@aws-cdk/core:validationReportJson';
@@ -90,7 +90,7 @@ function getAssemblies(root: App, rootAssembly: CloudAssembly): Map<string, Clou
  */
 function invokeValidationPlugins(root: IConstruct, outdir: string, assembly: CloudAssembly) {
   if (!App.isApp(root)) return;
-  const hash = computeChecksumOfFolder(outdir);
+  let hash: string | undefined;
   const assemblies = getAssemblies(root, assembly);
   const templatePathsByPlugin: Map<IPolicyValidationPluginBeta1, string[]> = new Map();
   visitAssemblies(root, 'post', construct => {
@@ -111,6 +111,11 @@ function invokeValidationPlugins(root: IConstruct, outdir: string, assembly: Clo
     // eslint-disable-next-line no-console
     console.log('Performing Policy Validations\n');
   }
+
+  if (templatePathsByPlugin.size > 0) {
+    hash = FileSystem.fingerprint(outdir);
+  }
+
   for (const [plugin, paths] of templatePathsByPlugin.entries()) {
     try {
       const report = plugin.validate({ templatePaths: paths });
@@ -126,7 +131,7 @@ function invokeValidationPlugins(root: IConstruct, outdir: string, assembly: Clo
         },
       });
     }
-    if (computeChecksumOfFolder(outdir) !== hash) {
+    if (FileSystem.fingerprint(outdir) !== hash) {
       throw new Error(`Illegal operation: validation plugin '${plugin.name}' modified the cloud assembly`);
     }
   }
@@ -162,21 +167,6 @@ function invokeValidationPlugins(root: IConstruct, outdir: string, assembly: Clo
   }
 }
 
-function computeChecksumOfFolder(folder: string): string {
-  const hash = createHash('sha256');
-  const files = fs.readdirSync(folder, { withFileTypes: true });
-
-  for (const file of files) {
-    const fullPath = path.join(folder, file.name);
-    if (file.isDirectory()) {
-      hash.update(computeChecksumOfFolder(fullPath));
-    } else if (file.isFile()) {
-      hash.update(fs.readFileSync(fullPath));
-    }
-  }
-  return hash.digest().toString('hex');
-}
-
 const CUSTOM_SYNTHESIS_SYM = Symbol.for('@aws-cdk/core:customSynthesis');
 
 /**
diff --git a/packages/aws-cdk-lib/core/test/synthesis.test.ts b/packages/aws-cdk-lib/core/test/synthesis.test.ts
index c196b023cdb82..4bd9ec3185eaa 100644
--- a/packages/aws-cdk-lib/core/test/synthesis.test.ts
+++ b/packages/aws-cdk-lib/core/test/synthesis.test.ts
@@ -272,6 +272,17 @@ describe('synthesis', () => {
     expect(stack.parameters).toEqual({ paramId: 'paramValue', paramId2: 'paramValue2' });
     expect(stack.environment).toEqual({ region: 'us-east-1', account: 'unknown-account', name: 'aws://unknown-account/us-east-1' });
   });
+
+  test('output folder checksum is not computed by default', () => {
+    const fingerprint = jest.spyOn(cdk.FileSystem, 'fingerprint');
+    const app = new cdk.App(); // <-- no validation plugins
+    const stack = new cdk.Stack(app, 'one-stack');
+    synthesize(stack);
+
+    expect(fingerprint).not.toHaveBeenCalled();
+
+    jest.restoreAllMocks();
+  });
 });
 
 function list(outdir: string) {