Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(synthetics): add support for puppeteer 3.4 runtime #19429

Merged
merged 8 commits into from
Mar 18, 2022
Merged

feat(synthetics): add support for puppeteer 3.4 runtime #19429

merged 8 commits into from
Mar 18, 2022

Conversation

ktheory
Copy link
Contributor

@ktheory ktheory commented Mar 17, 2022

Fixes #19382

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 17, 2022

@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Mar 17, 2022
kaizencc
kaizencc previously requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @ktheory! Some suggestions to get the build succeeding.

packages/@aws-cdk/aws-synthetics/lib/runtime.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-synthetics/test/integ.canary.ts Outdated
@@ -60,6 +60,15 @@ new synthetics.Canary(stack, 'MyCanaryThree', {
runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_3,
});

new synthetics.Canary(stack, 'MyCanaryFour', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you change an integ test you are going to have to update the corresponding expected.json file by running yarn integ -t integ.canary.js. But i don't think we need that for such a small change. i prefer if you just remove the changes to the integ test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer if you just remove the changes to the integ test.

Removed in 90c89a4

@mergify mergify bot dismissed kaizencc’s stale review March 17, 2022 17:13

Pull request has been modified.

kaizencc
kaizencc previously requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is still failing. I suggest you run ../../../scripts/buildup in the aws-synthetics folder to ensure that it's going to build. I'm going to mark this as exempt-test because we really don't need to test this.

packages/@aws-cdk/aws-synthetics/test/canary.test.ts Outdated
@@ -304,7 +304,7 @@ test('Schedule can be set with Cron', () => {
handler: 'index.handler',
code: synthetics.Code.fromInline('/* Synthetics handler code */'),
}),
runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_3,
runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_4,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not change this. Since we're not testing for runtime, it doesn't matter what we change in this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in 24855a9.

@kaizencc kaizencc added the pr-linter/exempt-test The PR linter will not require test changes label Mar 17, 2022
@ktheory
Fix the build
24855a9 
And revert the test change.
@mergify mergify bot dismissed kaizencc’s stale review March 17, 2022 19:22

Pull request has been modified.

@ktheory
Copy link
Contributor Author

ktheory commented Mar 17, 2022

@kaizen3031593 i think this is good now. Thanks for your quick feedback!

kaizencc
kaizencc approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktheory!

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 64c8741
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 024b890 into aws:master Mar 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

iliapolo pushed a commit that referenced this pull request Mar 20, 2022
@ktheory @iliapolo
feat(synthetics): add support for puppeteer 3.4 runtime (#19429)
df36827 
Fixes #19382


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

@kaizencc kaizencc

Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(synthetics): Add new runtime with Puppeteer 3.4
3 participants
@ktheory @aws-cdk-automation @kaizencc