Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servicecatalogappregistry: lookupFromName for application #20958

Open
1 of 2 tasks
RichiCoder1 opened this issue Jul 1, 2022 · 1 comment
Open
1 of 2 tasks

servicecatalogappregistry: lookupFromName for application #20958

RichiCoder1 opened this issue Jul 1, 2022 · 1 comment
Labels
@aws-cdk/aws-servicecatalogappregistry @aws-cdk/cx-api Related to the Cloud Executable API effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@RichiCoder1
Copy link
Contributor

RichiCoder1 commented Jul 1, 2022

Describe the feature

The ability to lookup a Service Catalog AppRegistry Application via it's Name or Id.

Use Case

Once #20850 lands, it'll be possible to create a central "application" and then share it. This will enable creating multi-env deployments and associating them back to a single application. A possible solution to make this work is to bootstrap the SCAR App and then store the Arn in context, but to make it more "automatic" it'd be nice to define a name and then look it up.

Proposed Solution

AWS SC AppRegistry exposes an API to get applications by name: https://docs.aws.amazon.com/servicecatalog/latest/dg/API_app-registry_GetApplication.html.

Expose this as Application.fromLookupName(<name>) which returns a hydrated application that can then be used to associateStack.

For efficiencies sake, it might make sense to have an opt in behavior (either via prop or flag) to have the context key not be account/env specific for the likely to be more common case that there's a single application which is then shared across org (and therefore is technically unique).

Other Information

An alternative would be a way to write out the resulting ARN from creation directly to context, but I'm not sure that's possible and/or desired? If that's possible though, it could obviate the need for this.

Related, there was a neat idea proposed here which had the potential idea of using AppRegistry as an integrated primitive. This FR could potentially underpin that behavior for multi-stack applications.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.30.0

Environment details (OS name and version, etc.)

N/A

@RichiCoder1 RichiCoder1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 1, 2022
@RichiCoder1 RichiCoder1 changed the title servicecatalogappregistry: lookupFrom[Name|Id] for application servicecatalogappregistry: lookupFromName for application Jul 1, 2022
@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort @aws-cdk/cx-api Related to the Cloud Executable API and removed needs-triage This issue or PR still needs to be triaged. labels Jul 28, 2022
@peterwoodworth
Copy link
Contributor

Thanks for the request! We handle lookups in our cx-api library 🙂

I am marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@kaizencc kaizencc removed their assignment Aug 24, 2022
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-servicecatalogappregistry @aws-cdk/cx-api Related to the Cloud Executable API effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

4 participants