Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eks: use lambda.Runtime.PYTHON_3_9 by default in kubectl-provider #25213

Closed
2 tasks
jarthur-scottlogic opened this issue Apr 20, 2023 · 5 comments
Closed
2 tasks

eks: use lambda.Runtime.PYTHON_3_9 by default in kubectl-provider #25213

jarthur-scottlogic opened this issue Apr 20, 2023 · 5 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@jarthur-scottlogic
Copy link

jarthur-scottlogic commented Apr 20, 2023 •
edited
Loading

Describe the feature

When creating a KubernetesManifest, a KubectlProvider is created that uses PYTHON_3_7 in its lambda. This should be upgraded to PYTHON_3_9.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-eks/lib/kubectl-provider.ts#L138

Use Case

All lambdas created by aws-cdk internally should be updated prior to EOL.

Proposed Solution

Update to PYTHON_3_9 when creating lambda in kubectl-provider

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.69.0

Environment details (OS name and version, etc.)

Windows 10 Enterprise, 21H2, 19044.2728
@jarthur-scottlogic jarthur-scottlogic added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 20, 2023
@pahud
Copy link
Contributor

pahud commented Apr 20, 2023

Yes we should bump the version upgrade before the EOL. I am making this p1 and the core team will evaluate it based on region availability. We will need to ensure all regions have python3.9 runtime before we bump this. Thank you for the report.

@pahud pahud added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2023
@watany-dev
Copy link
Contributor

I'll update to python 3.10.

@watany-dev watany-dev mentioned this issue Apr 27, 2023
Closed
@iliapolo iliapolo added the effort/medium Medium work item – several days of effort label May 16, 2023
@pahud
Copy link
Contributor

pahud commented Sep 18, 2023

related to #27031

@pahud
Copy link
Contributor

pahud commented Jun 18, 2024

It should be 3.10 now. Let me know if it isn't.

aws-cdk/packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/config.ts

Line 179 in b196b13

runtime: Runtime.PYTHON_3_10,

@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 18, 2024
@pahud pahud changed the title (aws-eks): use lambda.Runtime.PYTHON_3_9 by default in kubectl-provider eks: use lambda.Runtime.PYTHON_3_9 by default in kubectl-provider Jun 18, 2024
@github-actions GitHub Actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eks): Runtime EOL handling watany-dev/aws-cdk
4 participants
@pahud @iliapolo @watany-dev @jarthur-scottlogic