-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-gateway): add validation to variables
property on Stage
resource
#25267
fix(api-gateway): add validation to variables
property on Stage
resource
#25267
Conversation
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
variables
property on Stage
resourcevariables
property on Stage
resource
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
…ttps://github.com/aws/aws-cdk into sumughan/add-validation-variables-prop-api-gateway
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #3635
From the original issue: API Gateway Stage variables must match a regex to be valid (See the documentation). When adding variables using CDK, this regex is not enforced, so it can synthesize a CloudFormation template that cannot be deployed.
This PR fixes this issue by adding a validation that the strings match that regex along with a unit test for these changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license