-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-stepfunctions-tasks.apigateway: cross-region RestAPI not supported #26509
Labels
@aws-cdk/aws-stepfunctions-tasks
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
kiwi-33
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 26, 2023
Yes you are right. But looks like there's no region info in IRestApi. aws-cdk/packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts Lines 25 to 75 in 4103e79
Maybe we should provide a aws-cdk/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/apigateway/call-rest-api.ts Line 66 in 4103e79
|
pahud
added
p1
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 26, 2023
peterwoodworth
added
feature-request
A feature should be added or improved.
and removed
bug
This issue is a bug.
labels
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-stepfunctions-tasks
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Describe the bug
CDK builds an endpoint URL using the
region
of the Stack. This is a problem when I want to call a Rest API that is in a different region from the StepFunction.Expected Behavior
From a StepFunction in region-A, I can invoke a RestAPI in region-B.
Current Behavior
API Endpoint is always the same region as the stack
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/apigateway/call-rest-api.ts#L68 (it is built without consideration for the region.)
Reproduction Steps
this is the default behavior of the
CallApiGatewayRestApiEndpoint
class.Possible Solution
restApiRegion
can be passed as an optional parameter and is used when building the URL in thegetApiEndpoint()
method.Additional Information/Context
No response
CDK CLI Version
2.88.0
Framework Version
No response
Node.js Version
v16.20.0
OS
MacOS Darwin
Language
Typescript
Language Version
4.9.5
Other information
No response
The text was updated successfully, but these errors were encountered: