Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-codeartifact: CodeArtifact from lookup to get auth token and url #27511

Open
1 of 2 tasks
lpicchi opened this issue Oct 12, 2023 · 1 comment
Open
1 of 2 tasks

aws-codeartifact: CodeArtifact from lookup to get auth token and url #27511

lpicchi opened this issue Oct 12, 2023 · 1 comment
Labels
@aws-cdk/aws-codeartifact Related to the @aws-cdk/aws-codeartifact package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@lpicchi
Copy link

lpicchi commented Oct 12, 2023

Describe the feature

Ability to get CodeArtifact using a fromLookup function like Vpc.fromLookup and others.

Use Case

Currently the docs exmaple to get a CodeArtifact AuthToken is encouraging the use of aws-cli as an external process call. It is cleaner to use current CDK context credentials.

This could be used for any bundling Construct like PythonFunction that may need access to a private CodeArtifact repository to fetch packages.

Proposed Solution

I propose to implement this in the same way that other fromLookup resources are implemented currently.

Other Information

If you think this solution is fine. I can code it and create a pull request.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.100.0

Environment details (OS name and version, etc.)

All supported OS

@lpicchi lpicchi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-codeartifact Related to the @aws-cdk/aws-codeartifact package label Oct 12, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@khushail
Copy link
Contributor

@picchi-lucas , thanks for submitting this feature request and volunteering for PR.

Storing AuthToken in context file which would be valid for a short time might not be the coolest workaround (might defeat the purpose of creating the context.json file here). However we are open to feedback from the community and how it should be done.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codeartifact Related to the @aws-cdk/aws-codeartifact package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants