(@aws-cdk/aws-lambda-nodejs): fails on Windows when using pnpm

[brno32]

Describe the bug

I've installed pnpm on Windows using the following method from the docs https://pnpm.io/installation#on-windows

iwr https://get.pnpm.io/install.ps1 -useb | iex

this makes the command pnpm work in both Command Prompt and PowerShell. However the following line of code appends .cmd to the pnpm command

aws-cdk/packages/aws-cdk-lib/aws-lambda-nodejs/lib/package-manager.ts

Line 73 in 10b3221

os.platform() === 'win32' ? `${runCommand}.cmd` : runCommand,

Expected Behavior

for bundling to pass without errors

Current Behavior

Instead of pnpm.cmd, it should just invoke pnpm. Otherwise, when running cdk deploy with a node js lambda using pnpm as a package manager, you get the follow error during bundling

'pnpm.cmd' is not recognized as an internal or external command,
operable program or batch file.

Reproduction Steps

I've tried reproducing this in an isolated project but it didn't trigger the error, so I'm struggling to find out what scenario triggers pnpm.cmd to be fed to the shell

Possible Solution

Instead of pnpm.cmd, runBinCommand should just invoke pnpm when on Windows

Additional Information/Context

No response

CDK CLI Version

2.102.0

Framework Version

2.102.0

Node.js Version

v18.18.0

OS

Windows 11

Language

TypeScript

Language Version

5.2.2

Other information

No response

[peterwoodworth]

Hey, thanks for reporting this bug, and for linking to the code that might be causing this. We'll take a more in-depth look soon and get back to you

[khushail]

Hey @brno32 , thanks for reporting this. This needs to be taken into consideration, so marked as P1. However contributions from the community are welcome.

[thesobercoder]

For anyone facing the same issue, a workaround is to install PNPM as a dev dependency for the moment.