(EFS): Undocumented breaking change upgrading from 2.92 to 2.93+

[lamebear]

Describe the bug

This PR brought in an undocumented breaking change for existing deployments of EFS mount targets.

#26155

Expected Behavior

We expect for the name to stay the same in the generated CloudFormation

Current Behavior

The name of the resource changes, causing a replace action and the CloudFormation ChangeSet to fail.

Reproduction Steps

Upgrade aws-cdk-lib from <=2.92.0 to >=2.93.0 while have EFS mount targets

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.103

Framework Version

No response

Node.js Version

v18.18.2

OS

Linux,OSX,Windows

Language

TypeScript

Language Version

No response

Other information

File in above PR showing change to generated YAML:

d54b67d?diff=unified#diff-026b4716bf92acfe8e0d2d83d2c9e4cdd6f75c292c647ea14773ca5c542bfc9e

[matthiasgubler]

The breaking change was mentioned here, #25099 (comment) but mentioned feature-flag seems to be missing.

[matthiasgubler]

NVM. I found the feature-flag here: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cx-api/FEATURE_FLAGS.md#aws-cdkaws-efsmounttargetorderinsensitivelogicalid

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.