Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: compatibility with node v21 #28242

Closed
2 tasks
juweeks opened this issue Dec 4, 2023 · 7 comments
Closed
2 tasks

cli: compatibility with node v21 #28242

juweeks opened this issue Dec 4, 2023 · 7 comments
Labels
cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@juweeks
Copy link

juweeks commented Dec 4, 2023

Describe the feature

synthing with node v21 results in RuntimeError: Error: ENOENT: no such file or directory, open 'cdk.out/tree.json'

Use Case

node v21 was released 10/2023 and is the latest stable version

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.113.0

Environment details (OS name and version, etc.)

mac 13.6.1

@juweeks juweeks added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 4, 2023
@gordinmitya
Copy link

I can confirm this issue.
Just encountered on Ubuntu 23.10 with node v21.3.0 and cdk 2.113.0 (build ccd534a)

Stacktrace
jsii.errors.JavaScriptError: 
  @jsii/kernel.RuntimeError: Error: ENOENT: no such file or directory, open 'cdk.out/tree.json'
      at Kernel._Kernel_ensureSync (/tmp/tmpgc0na0y3/lib/program.js:10491:23)
      at Kernel.invoke (/tmp/tmpgc0na0y3/lib/program.js:9855:102)
      at KernelHost.processRequest (/tmp/tmpgc0na0y3/lib/program.js:11699:36)
      at KernelHost.run (/tmp/tmpgc0na0y3/lib/program.js:11659:22)
      at Immediate._onImmediate (/tmp/tmpgc0na0y3/lib/program.js:11660:46)
      at process.processImmediate (node:internal/timers:478:21)

Downgrading Node.js to v20.10.0 resolved the issue.

@khushail khushail added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2023
@khushail
Copy link
Contributor

khushail commented Dec 6, 2023

@juweeks , could you please share the specific scenario (repro code) where you faced this issue?

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-review labels Dec 6, 2023
@juweeks
Copy link
Author

juweeks commented Dec 6, 2023

@juweeks , could you please share the specific scenario (repro code) where you faced this issue?

There really isn't a specific scenario here.

  1. Synthed multiple CDK apps using lower node version and worked.
  2. Upgraded node n stable and it installed node v21.
  3. Tried synthing multiple CDK apps again on the upgraded node and got the runtime error on each synth.
  4. Downgraded to node v20 and synths worked again.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 6, 2023
@khushail khushail added needs-reproduction This issue needs reproduction. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 6, 2023
@khushail khushail self-assigned this Dec 6, 2023
@pahud
Copy link
Contributor

pahud commented Dec 12, 2023

@juweeks CDK is not fully tested in node v21 and we suggest to go to v20 instead.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-reproduction This issue needs reproduction. labels Dec 12, 2023
@juweeks
Copy link
Author

juweeks commented Dec 12, 2023

understood. that's why this is a feature request and not a bug report. would like to request that cdk be compatible with v21 if it's neither on a roadmap nor previously requested.

@pahud pahud added the cli Issues related to the CDK CLI label May 29, 2024
@khushail khushail removed their assignment Jul 17, 2024
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 12, 2024

We are unlikely to work on this since 20 and 22 are both stable Node versions and 21 is not.

@rix0rrr rix0rrr closed this as completed Nov 12, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

5 participants