(Route53): Cannot call addDelegation on hosted zones assembled from attributes

[moltar]

Describe the bug

A public hosted zone, assembled from attributes implements IHostedZone, which has the addDelegation method. This method requires the knowledge of hostedZoneNameServers, which I believe is not available when assembling from attributes.

Expected Behavior

One of:

1. Have another interface without the addDelegation method.
2. The addDelegation method should correctly check for hostedZoneNameServers and throw a meaningful error.

Current Behavior

An ambigous and user-hostile (due to the lack of source maps) error is thrown:

TypeError: Cannot read properties of undefined (reading 'map')
    at ZoneDelegationRecord (.../node_modules/.pnpm/[email protected][email protected]/node_modules/aws-cdk-lib/aws-route53/lib/record-set.js:1:10952)

Reproduction Steps

const iTestHostedZone = PublicHostedZone.fromHostedZoneAttributes(this, 'ITestHostedZone', {
  hostedZoneId: INTEGRATION_TEST_ROOT_HOSTED_ZONE_ID,
  zoneName: INTEGRATION_TEST_ROOT_ZONE_NAME,
})

const testHostedZone = new PublicHostedZone(this, 'HostedZone', {
  zoneName: [
    'foo',
    INTEGRATION_TEST_ROOT_ZONE_NAME,
  ].join('.'),
})

testHostedZone.addDelegation(iTestHostedZone)

Possible Solution

aws-cdk/packages/aws-cdk-lib/aws-route53/lib/hosted-zone.ts

Lines 363 to 372 in 03a5ecd

	public addDelegation(delegate: IPublicHostedZone, opts: ZoneDelegationOptions = {}): void {
	new ZoneDelegationRecord(this, `${this.zoneName} -> ${delegate.zoneName}`, {
	zone: this,
	recordName: delegate.zoneName,
	nameServers: delegate.hostedZoneNameServers!, // PublicHostedZones always have name servers!
	comment: opts.comment,
	ttl: opts.ttl,
	});
	}
	}

1. Do not use bang to satisfy the compiler (delegate.hostedZoneNameServers! <---), this is already a code smell.
2. Use proper assertion to both provide user a good error message, and type narrow: assert(delegate.hostedZoneNameServers, 'No name servers')

Additional Information/Context

N/A

CDK CLI Version

2.111.0

Framework Version

2.100.0

Node.js Version

v18.12.1

OS

macOS

Language

TypeScript

Language Version

No response

Other information

No response

[moltar]

Closing as a duplicate of #3558

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.