Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotswap: we don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. #30933

Open
2 tasks
jpangburn opened this issue Jul 24, 2024 · 3 comments
Labels
@aws-cdk/aws-amplify Related to AWS Amplify effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. hotswap p3

Comments

@jpangburn
Copy link

Describe the feature

I'm using AWS Amplify Gen 2, and every time I update my lambda functions it does a full deployment. It blames CDK and requests it be reported here:

Could not perform a hotswap deployment, because the CloudFormation template could not be resolved: We don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. Please report it at https://github.com/aws/aws-cdk/issues/new/choose

Use Case

Everyone who is using Amplify Gen 2, and uses SQS queues in their backend.ts CDK definition is/will run into this. For example, I have a bit of CDK code like:

const accessLogsDLQ = new sqs.Queue(logNotificationStack, "AccessLogsDLQ", {
  retentionPeriod: Duration.days(7), // keep problematic events for 7 days
});

It's part of a queue definition for my lambda functions to write to. Because of this, every time I update a lambda function or change anything about my backend, it does a full deployment which takes a while. It's a pretty high impact to the development flow of Amplify Gen 2 if you need an SQS queue, which I imagine most serious projects will use at some point.

Proposed Solution

Maybe work with the Amplify team, find out who wrote this warning message into their code instead of submitting this bug/feature report themselves, and ask them what they need :-)

Other Information

For working on parts of the application that don't involve the queues, it's possible to comment all that out but this is likely to lead to unintended consequences in development and seems like a poor workaround.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.147.0

Environment details (OS name and version, etc.)

Mac OS Sonoma 14.5

@jpangburn jpangburn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 24, 2024
@github-actions github-actions bot added the @aws-cdk/aws-amplify Related to AWS Amplify label Jul 24, 2024
@pahud
Copy link
Contributor

pahud commented Jul 24, 2024

reaching out to Amplify team for clarifying

internal tracking: V1462555712

@pahud pahud added p3 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 24, 2024
@jpangburn
Copy link
Author

@pahud thanks for looking into this!

@pahud pahud added the hotswap label Jul 25, 2024
@pahud pahud changed the title (amplify Gen 2): We don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. hotswap: We don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. Jul 25, 2024
@pahud pahud changed the title hotswap: We don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. hotswap: we don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. Jul 25, 2024
@pahud
Copy link
Contributor

pahud commented Jul 25, 2024

At this moment, CDK hotswap is only supported for those resources.

Making it a hotswap feature request for SQS Queue. Please help us prioritize with 👍

Adding hotswap label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-amplify Related to AWS Amplify effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. hotswap p3
Projects
None yet
Development

No branches or pull requests

2 participants