Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-virtual-mfa-device output file QRCode.png can't be opened/viewed #970

Closed
hydrajump opened this issue Oct 25, 2014 · 2 comments · Fixed by #1015
Closed

create-virtual-mfa-device output file QRCode.png can't be opened/viewed #970

hydrajump opened this issue Oct 25, 2014 · 2 comments · Fixed by #1015
Assignees
@jamesls
Labels
bug This issue is a bug.

Comments

@hydrajump
Copy link

I'm using the following command to create a MFA device,

aws iam create-virtual-mfa-device --virtual-mfa-device-name hydrajump --bootstrap-method QRCodePNG --outfile "/Users/hydrajump/Downloads/QRCode.png"

The output file QRCode.png can't be opened with Preview.app and I get the following error,

"It may be damaged or use a file format that Preview doesn’t recognise."

Do I need a special QR code viewer?
@jamesls
Copy link
Member

jamesls commented Oct 31, 2014

Looks like a regression on our end. Working on a fix. Thanks for reporting.

@jamesls jamesls added bug This issue is a bug. confirmed labels Oct 31, 2014
@jamesls jamesls self-assigned this Oct 31, 2014
quiver added a commit to quiver/aws-cli that referenced this issue Nov 14, 2014
@quiver
remove unnecessary decoding process for mfa device creation
c06047a 
This fixes an issue where `aws iam create-virtual-mfa-device` tries to
base64-decode already base64-decoded data.
2nd decoding results in decoding error or malformed data.

fixes aws#970
@quiver quiver mentioned this issue Nov 14, 2014
Closed
@quiver
Copy link
Contributor

quiver commented Nov 14, 2014

PR #1005 should fix this.

"It may be damaged or use a file format that Preview doesn’t recognise."

Decoding already-decoded data was the culprit.

@jamesls jamesls mentioned this issue Nov 19, 2014
Closed
jamesls added a commit to jamesls/aws-cli that referenced this issue Nov 20, 2014
@jamesls
Add customization to alter scalar parsing behavior
e19491d 
This fixes aws#1001.  This also fixes a regression we had
when displaying binary content.

As mentioned on the github issue, we were previously always
showing binary content as base64 encoded.  This PR adds back
this behavior.

In addition, this also gives us a hook into changing the
timestamp parsing so we can later add a config option to
unify the way timestamps are displayed.

Also fixes aws#970, and closes aws#1005.

I've also added an integration test for aws#1001 to ensure
we are in fact displaying a response that can be printed to
stdout.
@jamesls jamesls mentioned this issue Nov 20, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesls jamesls

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
3 participants
@quiver @jamesls @hydrajump