Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sam deploy is showing parameters with NoEcho: true #2210

Closed
kstro21 opened this issue Sep 10, 2020 · 3 comments
Closed

sam deploy is showing parameters with NoEcho: true #2210

kstro21 opened this issue Sep 10, 2020 · 3 comments
Assignees
Labels

Comments

@kstro21
Copy link

kstro21 commented Sep 10, 2020

Description

If I add a parameter to my template and set the NoEcho option to true, then, when I run sam deploy with --parameter-overrides I can see the value of the parameter in the command output.

Steps to reproduce

  1. Add a parameter with NoEcho: true
    MyParam:
       Type: String
       Description: My description
       NoEcho: true
  2. Invoke sam deploy like this:
    sam deploy --stack-name my-stack --parameter-overrides MyParam=$SOME_ENV_VAR \
     --region $AWS_REGION --s3-bucket $FZ_BUCKET_NAME \
     --s3-prefix my-app-prefix --capabilities CAPABILITY_IAM --force-upload

Observed result

Deploying with following values
--
253 | ===============================
254 | Stack name                 : my-stack
255 | Region                     : us-east-1
256 | Confirm changeset          : False
257 | Deployment s3 bucket       : my-bucket
258 | Capabilities               : ["CAPABILITY_IAM"]
259 | Parameter overrides        : {'MyParam': 'ShouldntSeeThis'}

Expected result

I shouldn't see parameters with NoEcho: true in the cli output. It is ok if I'm local, but I don't want those values in my CI/CD pipeline's log

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

  1. sam --version: 1.2.0
@wchengru wchengru added the stage/pm-review Waiting for review by our Product Manager, please don't work on this yet label Sep 11, 2020
@wchengru wchengru self-assigned this Sep 11, 2020
@wchengru wchengru removed the stage/pm-review Waiting for review by our Product Manager, please don't work on this yet label Sep 11, 2020
@vaunus
Copy link

vaunus commented Dec 9, 2020

+1 am also seeing the same issue. Would be good to get this merged in.

@wchengru wchengru added the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Jan 25, 2021
@aahung
Copy link
Contributor

aahung commented Jan 30, 2021

it is released in v1.16.0, please reopen if the issue still persists

@aahung aahung closed this as completed Jan 30, 2021
@aahung aahung removed the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Jan 30, 2021
@snoblenet
Copy link

snoblenet commented Mar 17, 2021

I am experiencing this issue with SAM CLI v1.20.0 and the --debug flag, which I'd expect to result in secret params being obscured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants