Bug: Serverless Api: Incorrect handling of !If statement

[bel-gacem]

Description:

Hi, looks like the Domain property of the serverless api resource does not support !If statement.

Steps to reproduce:

Conditions:
  EnableCustomDomain: !Not [!Equals [!Ref SubDomainName, '']]
Resources:
  RestApi:
    Type: AWS::Serverless::Api
    Properties:
      Name: !Sub restapi-${Deployment}
      StageName: v1
      OpenApiVersion: 3.0.3
      DefinitionBody: !Transform
        Name: AWS::Include
        Parameters:
          Location: spec/openapi.yaml
      EndpointConfiguration:
        Type: REGIONAL
      Domain: !If
        - EnableCustomDomain
        - DisableExecuteApiEndpoint: true
          BasePath:
            - /v1
          CertificateArn: !Ref SSLCertificateArn
          DomainName: !Sub ${DnsHostId}.${SubDomainName}
          EndpointConfiguration: REGIONAL
          SecurityPolicy: TLS_1_2
          Route53:
            HostedZoneName: !Sub ${SubDomainName}.
        - !Ref AWS::NoValue

Observed result:

$ sam validate
[[E0001: Error found when transforming the template] (Error transforming template: Resource with id [RestApi] is invalid. Property 'Domain.DomainName' is required.) matched 1]
Error: Linting failed. At least one linting rule was matched to the provided template.

$ sam deploy
Waiting for changeset to be created..
Error: Failed to create changeset for the stack: app-dev, ex: Waiter ChangeSetCreateComplete failed: Waiter encountered a terminal failure state: For expression "Status" we matched expected path: "FAILED" Status: FAILED. Reason: Transform AWS::Serverless-2016-10-31 failed with: Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [RestApi] is invalid. Property 'Domain.DomainName' is required.

Expected result:

Both the validation and the deployment are successful.

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

1. OS: Ubuntu 22.04.3 LTS
2. sam --version: 1.123.0
3. AWS region: us-east-1

{
  "version": "1.123.0",
  "system": {
    "python": "3.11.8",
    "os": "Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.35"
  },
  "additional_dependencies": {
    "docker_engine": "24.0.5",
    "aws_cdk": "Not available",
    "terraform": "1.7.3"
  },
  "available_beta_feature_env_vars": [
    "SAM_CLI_BETA_FEATURES",
    "SAM_CLI_BETA_BUILD_PERFORMANCE",
    "SAM_CLI_BETA_TERRAFORM_SUPPORT",
    "SAM_CLI_BETA_RUST_CARGO_LAMBDA"
  ]
}

[hnnasit]

Hi @bel-gacem, SAM and SAM CLI has some basic intrinsics support, but unfortunately it doesn't cover all cases. Have a look at the SAM issue to check the unsupported intrinsics.

[bel-gacem]

Thanks @hnnasit, closing the issue.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.