Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 address support in S3 #1857

Closed
drake127 opened this issue Jan 31, 2022 · 3 comments
Closed

IPv6 address support in S3 #1857

drake127 opened this issue Jan 31, 2022 · 3 comments
Labels
closed-for-staleness feature-request A feature should be added or improved. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days.

Comments

@drake127
Copy link

Describe the bug

The commit cb67425 introduced IPv6 address support in AWS core but it's still failing in AWSClient.cpp and function Aws::Utils::IsValidHost()

Expected behavior

Connection to http://[::1]:8000 should work.

Current behavior

Currently, the request fails with Invalid DNS Label found in URI host error

Steps to Reproduce

Create an S3 bucket using bracketed IPv6 address with explicit port, e.g. http://[::1]:8000

Possible Solution

It appears that half-work is already done and Aws::Utils::IsValidHost needs to understand bracketed GetAuthority, or rather IPs.

AWS CPP SDK version used

1.9.185

Compiler and Version used

gcc-9

Operating System and version

Ubuntu 20.04

@drake127 drake127 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2022
@KaibaLopez
Copy link
Contributor

Hi @drake127 ,
Hmmm... So you are right about it not working, but I am pretty sure this is something we don't support for s3 yet... just a matter of syntax but I think this is a feature in the works rather than a bug.

@KaibaLopez KaibaLopez added feature-request A feature should be added or improved. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2022
@jmklix jmklix added bug This issue is a bug. p2 This is a standard priority issue needs-review This issue or pull request needs review from a core team member. and removed feature-request A feature should be added or improved. labels Jan 13, 2023
@jmklix jmklix added feature-request A feature should be added or improved. and removed bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. labels Mar 10, 2023
@DmitriyMusatkin
Copy link
Contributor

This should now be supported in 1.11 with the rule based endpoint resolution which does understand ipv6 endpoint overrides.

@DmitriyMusatkin DmitriyMusatkin added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Jun 28, 2024
Copy link

github-actions bot commented Jul 9, 2024

Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness feature-request A feature should be added or improved. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days.
Projects
None yet
Development

No branches or pull requests

4 participants