Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bundle exports #281

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Fixing bundle exports #281

merged 1 commit into from
Nov 10, 2017

Conversation

shorea
Copy link
Contributor

@shorea shorea commented Nov 10, 2017

Description

Adding missing dependencies to bundle pom.

Motivation and Context

Make the bundle usable.

Testing

Used the bundle in an application

Screenshots (if appropriate)

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [ x] I have read the CONTRIBUTING document
  • [ x] Local run of mvn install succeeds
  • [ x] My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • [x ] I have read the README document
  • I have added tests to cover my changes
  • [x ] All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • [x ] I confirm that this pull request can be released under the Apache 2 license

@spfink
Copy link
Contributor

spfink commented Nov 10, 2017

When do we need to specify relocations?

@shorea
Copy link
Contributor Author

shorea commented Nov 10, 2017

When do we need to specify relocations?

I'd say generally only for problematic dependencies that are known to cause conflicts. Things like reactive streams/logging facades are safe I think, maybe we should consider relocating Netty

@shorea shorea merged commit a4db869 into master Nov 10, 2017
@zoewangg zoewangg deleted the shorea-bundle-fixes branch December 6, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants