feat(credential-providers): pass caller client options to fromTemporaryCredentials inner STSClient #6838
+231
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryCredentials inner STSClient
kuhe
force-pushed
the
feat/fromTempCreds
branch
from
2ffc611 to
2ba842b
Compare
kuhe
commented
Jan 22, 2025
| @@ -84,7 +84,7 @@ const resolveRegion = async ( | |||
| */ | |||
| export const getDefaultRoleAssumer = ( | |||
| stsOptions: STSRoleAssumerOptions, | |||
| stsClientCtor: new (options: STSClientConfig) => STSClient | |||
| STSClient: new (options: STSClientConfig) => STSClient | |||
There was a problem hiding this comment.
renamed this variable so searching new STS is more consistent
kuhe
force-pushed
the
feat/fromTempCreds
branch
from
dc94fd5 to
b39a5c3
Compare
siddsriv
approved these changes
Jan 22, 2025
trivikr
approved these changes
Jan 22, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6565
Description
fromTemporaryCredentialsinner STS client unless overridden withfromTemporaryCredentials({ clientConfig })fields.Testing
new unit tests
existing credential integration tests