Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing access to secret's metadata #11

Open
cmorgia opened this issue Feb 4, 2020 · 2 comments
Open

Providing access to secret's metadata #11

cmorgia opened this issue Feb 4, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@cmorgia
Copy link

cmorgia commented Feb 4, 2020

Hi,
I'm working on my fork to slightly modify the source code in order to provide visibility on the secret's metadata.
This information is coming through DescribeSecret and it's already cached in the SecretCacheObject.

I would like to submit a pull request to your repository and my proposal would be to change the SecretCacheObject.getResult method to public and implement a SecretCache.describeSecret method like the following:

/**
     * Method to retrieve the description of a secret from AWS Secrets Manager.
     *
     * @param secretId
     *        The identifier for the secret being requested.
     * @return The string secret
     */
    public DescribeSecretResult describeSecret(final String secretId) {
        SecretCacheItem secret = this.getCachedSecret(secretId);
        return secret.getResult().clone();
    }

This way, accessing the secret's metadata does not request a second trip to the AWS SecretsManager or the implementation of a secondary cache.

This is my first pull request here, please be nice ;-)

@parimaldeshmukh
Copy link

Thank you for your feedback. We have noted this as a feature request.

@parimaldeshmukh parimaldeshmukh added the enhancement New feature or request label May 17, 2021
@aaaeeeo
Copy link

aaaeeeo commented Feb 28, 2022

+1
I would like to get versions other then CURRENT for a secret, I didn't find a way to do this right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants