You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I'm working on my fork to slightly modify the source code in order to provide visibility on the secret's metadata.
This information is coming through DescribeSecret and it's already cached in the SecretCacheObject.
I would like to submit a pull request to your repository and my proposal would be to change the SecretCacheObject.getResult method to public and implement a SecretCache.describeSecret method like the following:
/**
* Method to retrieve the description of a secret from AWS Secrets Manager.
*
* @param secretId
* The identifier for the secret being requested.
* @return The string secret
*/
public DescribeSecretResult describeSecret(final String secretId) {
SecretCacheItem secret = this.getCachedSecret(secretId);
return secret.getResult().clone();
}
This way, accessing the secret's metadata does not request a second trip to the AWS SecretsManager or the implementation of a secondary cache.
This is my first pull request here, please be nice ;-)
The text was updated successfully, but these errors were encountered:
Hi,
I'm working on my fork to slightly modify the source code in order to provide visibility on the secret's metadata.
This information is coming through
DescribeSecret
and it's already cached in theSecretCacheObject
.I would like to submit a pull request to your repository and my proposal would be to change the
SecretCacheObject.getResult
method to public and implement aSecretCache.describeSecret
method like the following:This way, accessing the secret's metadata does not request a second trip to the AWS SecretsManager or the implementation of a secondary cache.
This is my first pull request here, please be nice ;-)
The text was updated successfully, but these errors were encountered: