Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogErrorContextMissingStrategy stack trace logging bug #234

Closed
friscoMad opened this issue Nov 10, 2020 · 1 comment
Closed

LogErrorContextMissingStrategy stack trace logging bug #234

friscoMad opened this issue Nov 10, 2020 · 1 comment
Labels

Comments

@friscoMad
Copy link
Contributor

In #191 it was introduced a debug trace to show the stack trace when a context error was suppressed, it is really nice to find out places that neede to be corrected, except it is doesn't work as expected, this is the trace it produces:
[LogErrorContextMissingStrategy] java.lang.RuntimeException: Failed to end subsegment: subsegment cannot be found.

The throwable should be the second param and a message should be added as the first param, otherwise, Apache logging just calls toString on the first param to get the message.

@willarmiros
Copy link
Contributor

Thanks for raising this @friscoMad, silly miss on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants