-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of dependencies to comply with Whitesource security scan #333
Comments
Thanks for raising this question, we are working on upgrade the |
As far as I can see in https://github.com/aws/aws-sdk-java/blob/master/pom.xml AWS Java SDK 1.12.228 still uses Joda Time 2.8.1 which is not accepted by WhiteSource (library version released on 15 Jun 2015). |
@SebastianCelejewski Unfortunately it looks like the AWS Java SDK team doesn't have any plans to remove Joda Time like they did for Jackson. They need to maintain backwards compatibility with Java 6 and that's why they can't remove it. See aws/aws-sdk-java#1580. As always, ADOT (AWS Distro for OTel) Java has full GA support by the X-Ray team, so it is a great alternative to the X-Ray Java SDK with a superset of features. |
@NathanielRN joda-time by itself is fine, it's just this obsolete version what is the problem. If they could update it to some more recent version it would be fine. I see that the last version is 2.10.14 from March 2022. It's still version 2 so probably there aren't any breaking changes. |
@PiotrWu Do you think we can continue the conversation on that GitHub issue there in that case? Since without a newer AWS Java SDK, we can’t unblock the issue here on X-Ray side, unless we used V2 somehow but that would be a bigger feature request for the X-Ray SDK here. |
@NathanielRN sure. |
At our company we're using Whitesource software for detection of the security issues. Unfortunately the newest version (2.11.1) of aws-xray-recorder-sdk-core doesn't comply with our policy. Some libraries have serious vulnerabilities and some are just old (joda-time is 7 years old). Below is the list of libraries that were rejected in a security scan.
Most if not all of these problematic dependencies come from aws-java-sdk-core library which should also be updated.
Please consider this request as without these changes it becomes impossible to use xray.
The text was updated successfully, but these errors were encountered: