Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appmesh-gateway] nodeSelector indentation wrong #473

Open
yanwsh opened this issue Mar 17, 2021 · 0 comments · May be fixed by #1154
Open

[appmesh-gateway] nodeSelector indentation wrong #473

yanwsh opened this issue Mar 17, 2021 · 0 comments · May be fixed by #1154
Labels
bug Something isn't working

Comments

@yanwsh
Copy link

yanwsh commented Mar 17, 2021

Describe the bug
I am trying to add nodeSelector, but it throws error from k8s. I think the indentation is wrong.

https://github.com/aws/eks-charts/blob/master/stable/appmesh-gateway/templates/deployment.yaml#L71

Steps to reproduce
add code

    const gatewayChart = new HelmChart(this, 'AppMeshGatewayHelmChart', {
      cluster,
      namespace,
      repository: 'https://aws.github.io/eks-charts',
      chart: 'appmesh-gateway',
      release: 'appmesh-gateway',
      version: '0.1.5',
      values: {
        nodeSelector:{
            nodeType: 'system',
        },
      },
    });

throw exception:

unable to build kubernetes objects from release manifest: error validating "": 
error validating data: ValidationError(Deployment.spec.template.spec): 
unknown field "nodeType" in io.k8s.api.core.v1.PodSpec\n' 

Expected outcome
should not throw error

Environment

  • Chart name: appmesh-gateway
  • Chart version: 0.1.5
  • Kubernetes version: 1.19
  • Using EKS (yes/no), if so version? yes

Additional Context:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant