Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gremlin cleanup #452

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Gremlin cleanup #452

merged 6 commits into from
Jun 21, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 21, 2024

Description

There was not much to do as far as Gremlin optimizations. So I took the opportunity to cleanup the code a bit.

  • Use function syntax
  • Use normalize when it helps
  • Add normalizeWithNoSpace as an alternative which is good for Gremlin queries
  • Add index.ts for testing utils and fix imports

Validation

  • Verified with quick smoke test

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 21, 2024 21:08
@kmcginnes kmcginnes marked this pull request as ready for review June 21, 2024 21:08
@kmcginnes kmcginnes merged commit fb131dc into aws:main Jun 21, 2024
1 check passed
@kmcginnes kmcginnes deleted the gremlin-formatting branch June 21, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants