feat(NuGet): Support NuGet GitHub Packages #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Lmk when ready |
@eladb Everything should be good to go. I've tested both GitHub and nuget.org. Also tried using the published packages in a project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes required.
nuget_sourcethroughNUGET_SERVERenv var. Defaults to nuget.orgUseExpand existing conflict check to work for GitHub.--skip-duplicateoption. Could also add additional error string checks, but seems better to use built-in support for ignoring conflicts.skip-duplicateseemed to work on nuget.org for the main package, but didn't work correctly for the symbols package.I have tested new and conflict states on GitHub and nuget.org. Also using the package in a project.