feat(golang): Support Multi-version and root level modules #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Feb 7, 2021
eladb
suggested changes
Feb 7, 2021
|
@eladb Have another look? There's a lot here because of a bunch of test fixtures and the switch to an updated projen |
eladb
suggested changes
Feb 9, 2021
|
Added do not merge |
mergify bot
pushed a commit
to projen/projen
that referenced
this pull request
Aug 26, 2024
Removes the `githubRepo` from `projen.release.GoPublishOptions` and `projen.jsii.JsiiGoTarget`. This option was removed in publib over 3 years ago via cdklabs/publib#34 and had no effect. It was just just confusing for users. Adds the `versionSuffix` option which has been supported by jsii for a while. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script will now support both root level modules, and modules located in subdirectories.
Sub modules
Root modules
The script also supports a combined structure, in which case it knows to differentiate between root and sub modules for correctly creating the tags.
And oh yeah, it's completely re-written in TypeScript :)
Fixes #28
Fixes #33