fix(go): Release is not idempotent to existing tags #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
commented
Apr 13, 2021
| @@ -36,22 +36,27 @@ export interface RunOptions { | |||
| */ | |||
| export function run(command: string, options: RunOptions = {}): string { | |||
| const shsplit = shlex.split(command); | |||
| const pipe = options.capture ?? false; | |||
| const pipeOrInherit = (options.capture ?? false) ? 'pipe': 'inherit'; | |||
There was a problem hiding this comment.
We now need stderr piping as well.
| const cwd = process.cwd(); | ||
| try { | ||
| process.chdir(repoDir); | ||
| git.init(); | ||
| git.add('.'); | ||
| git.identify('jsii-release-test', '<>'); | ||
| git.commit('Initial Commit'); | ||
| if (postInit) { postInit(repoDir); }; |
There was a problem hiding this comment.
A way for tests to influence the target repository.
eladb
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on CI workflows, it might be that
jsii-releasewill execute with the same version, but different branch content.For example, the release workflow of
cdk8sruns on every push tomaster, which may introduce changes to the generated go code, but without a version bump.In this case we want to skip the release, instead of failing.
This PR will make sure it only pushes non-existing tags, and if no such tags exist, the release will be skipped.