feat(go): emit indirect dependencies in go.mod #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps IDEs (eg: GoLand from JetBrains, etc..) be more comfortable with the codebase, as indirect dependencies are correctly mapped. This generates code more in line with what `go mod` would have generated if one had tried to manually generate those packages.
RomainMuller
added
language/go
RomainMuller
commented
Feb 23, 2021
| )}`, | ||
| ); | ||
| for (const dep of this.packageDependencies) { | ||
| code.line(`${JSII_RT_MODULE_NAME} v${VERSION}`); |
There was a problem hiding this comment.
The previous code was actually incorrect - the version of the jsii runtime to link against must correspond to the version of jsii-pacmak that generated the code, NOT the version of jsii that created the assembly.
eladb
approved these changes
Feb 23, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps IDEs (eg: GoLand from JetBrains, etc..) be more comfortable
with the codebase, as indirect dependencies are correctly mapped. This
generates code more in line with what
go modwould have generated ifone had tried to manually generate those packages.
This was manually confirmed to have a fully working experience in GoLand,
where even generated code modules are completely browsable, compiling,
and IntelliSense-able in this configuration; while previously it would be
unable to build and check the generated code, resulting in an extremely
poor experience (with UIs jumping around as the IDE failed to resolve modules).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.