Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Keep Track of v1alpha5.Machine in Cluster State #170

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jan 19, 2023

Fixes #

Description

  • Keep Track of v1alpha5.Machine in Cluster State
  • Add cluster.Synced to the cluster state to prep for provisioning to wait on Machine creation and resolution before starting another provisioning round.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch 6 times, most recently from c22c4e6 to 8a6812e Compare January 19, 2023 23:32
@coveralls
Copy link

coveralls commented Jan 19, 2023

Pull Request Test Coverage Report for Build 3989817122

  • 245 of 309 (79.29%) changed or added relevant lines in 15 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.6%) to 77.756%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/metrics/state/scraper/node.go 2 4 50.0%
pkg/controllers/state/node.go 102 110 92.73%
pkg/controllers/counter/controller.go 0 9 0.0%
pkg/utils/sets/sets.go 0 9 0.0%
pkg/controllers/state/informer/machine.go 16 27 59.26%
pkg/controllers/state/cluster.go 72 97 74.23%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/scheduler.go 1 96.83%
pkg/controllers/state/cluster.go 1 84.07%
pkg/controllers/deprovisioning/controller.go 2 70.81%
pkg/scheduling/requirements.go 2 98.5%
Totals Coverage Status
Change from base Build 3952667031: 0.6%
Covered Lines: 6044
Relevant Lines: 7773

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch 4 times, most recently from 430b00e to a7aaab8 Compare January 20, 2023 00:26
pkg/controllers/counter/controller.go Show resolved Hide resolved
pkg/controllers/deprovisioning/helpers.go Outdated Show resolved Hide resolved
pkg/controllers/state/node.go Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch from a7aaab8 to 5057473 Compare January 20, 2023 18:28
@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch 2 times, most recently from 4be9c89 to 9b0b60f Compare January 20, 2023 19:11
@jonathan-innis jonathan-innis requested a review from tzneal January 20, 2023 19:13
@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch 5 times, most recently from ff144f8 to a53968f Compare January 20, 2023 19:29
@jonathan-innis jonathan-innis marked this pull request as ready for review January 20, 2023 19:29
@jonathan-innis jonathan-innis requested a review from a team as a code owner January 20, 2023 19:29
@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch 3 times, most recently from 392b8b5 to a1d6565 Compare January 20, 2023 19:46
@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch 3 times, most recently from ba4d7a4 to 2edd4c9 Compare January 20, 2023 20:08
@jonathan-innis jonathan-innis requested a review from tzneal January 23, 2023 19:23
@jonathan-innis jonathan-innis force-pushed the cluster-state-with-machine branch from 2edd4c9 to 195f44d Compare January 23, 2023 19:23
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit d04b91e into kubernetes-sigs:main Jan 25, 2023
@jonathan-innis jonathan-innis deleted the cluster-state-with-machine branch January 25, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants