-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Keep Track of v1alpha5.Machine
in Cluster State
#170
Merged
jonathan-innis
merged 5 commits into
kubernetes-sigs:main
from
jonathan-innis:cluster-state-with-machine
Jan 25, 2023
Merged
chore: Keep Track of v1alpha5.Machine
in Cluster State
#170
jonathan-innis
merged 5 commits into
kubernetes-sigs:main
from
jonathan-innis:cluster-state-with-machine
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
6 times, most recently
from
January 19, 2023 23:32
c22c4e6
to
8a6812e
Compare
Pull Request Test Coverage Report for Build 3989817122
💛 - Coveralls |
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
4 times, most recently
from
January 20, 2023 00:26
430b00e
to
a7aaab8
Compare
tzneal
reviewed
Jan 20, 2023
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
from
January 20, 2023 18:28
a7aaab8
to
5057473
Compare
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
2 times, most recently
from
January 20, 2023 19:11
4be9c89
to
9b0b60f
Compare
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
5 times, most recently
from
January 20, 2023 19:29
ff144f8
to
a53968f
Compare
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
3 times, most recently
from
January 20, 2023 19:46
392b8b5
to
a1d6565
Compare
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
3 times, most recently
from
January 20, 2023 20:08
ba4d7a4
to
2edd4c9
Compare
tzneal
reviewed
Jan 23, 2023
jonathan-innis
force-pushed
the
cluster-state-with-machine
branch
from
January 23, 2023 19:23
2edd4c9
to
195f44d
Compare
tzneal
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
v1alpha5.Machine
in Cluster Statecluster.Synced
to the cluster state to prep for provisioning to wait on Machine creation and resolution before starting another provisioning round.How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.