-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Alter tracking bindings in testing (ExpectProvisioned
, etc.)
#193
Merged
jonathan-innis
merged 2 commits into
kubernetes-sigs:main
from
jonathan-innis:alter-bindings-tracking
Feb 1, 2023
Merged
test: Alter tracking bindings in testing (ExpectProvisioned
, etc.)
#193
jonathan-innis
merged 2 commits into
kubernetes-sigs:main
from
jonathan-innis:alter-bindings-tracking
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
alter-bindings-tracking
branch
from
February 1, 2023 19:39
4a89f26
to
a4a224c
Compare
jonathan-innis
force-pushed
the
alter-bindings-tracking
branch
4 times, most recently
from
February 1, 2023 21:31
28123a3
to
434296e
Compare
jonathan-innis
changed the title
test: Alter tracking bindings in testing
test: Alter tracking bindings in testing (Feb 1, 2023
ExpectProvisioned
, etc.)
jonathan-innis
force-pushed
the
alter-bindings-tracking
branch
4 times, most recently
from
February 1, 2023 21:38
2c393cd
to
d7bddc6
Compare
Pull Request Test Coverage Report for Build 4069329710
💛 - Coveralls |
ellistarn
reviewed
Feb 1, 2023
ellistarn
reviewed
Feb 1, 2023
jonathan-innis
force-pushed
the
alter-bindings-tracking
branch
from
February 1, 2023 22:15
d7bddc6
to
5a061d1
Compare
Good feedback @ellistarn |
ellistarn
previously approved these changes
Feb 1, 2023
jonathan-innis
force-pushed
the
alter-bindings-tracking
branch
from
February 1, 2023 22:33
5a061d1
to
0e29e9c
Compare
ellistarn
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
ExpectProvisioned
functions and are used to create the bindings to bind the pods to the nodes during schedulingHow was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.