Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Alter tracking bindings in testing (ExpectProvisioned, etc.) #193

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Feb 1, 2023

Fixes #

Description

  • Alter tracking bindings in testing
  • Bindings are now returned from the ExpectProvisioned functions and are used to create the bindings to bind the pods to the nodes during scheduling

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis force-pushed the alter-bindings-tracking branch from 4a89f26 to a4a224c Compare February 1, 2023 19:39
@jonathan-innis jonathan-innis force-pushed the alter-bindings-tracking branch 4 times, most recently from 28123a3 to 434296e Compare February 1, 2023 21:31
@jonathan-innis jonathan-innis marked this pull request as ready for review February 1, 2023 21:33
@jonathan-innis jonathan-innis requested a review from a team as a code owner February 1, 2023 21:33
@jonathan-innis jonathan-innis changed the title test: Alter tracking bindings in testing test: Alter tracking bindings in testing (ExpectProvisioned, etc.) Feb 1, 2023
@jonathan-innis jonathan-innis force-pushed the alter-bindings-tracking branch 4 times, most recently from 2c393cd to d7bddc6 Compare February 1, 2023 21:38
@coveralls
Copy link

coveralls commented Feb 1, 2023

Pull Request Test Coverage Report for Build 4069329710

  • 81 of 88 (92.05%) changed or added relevant lines in 8 files are covered.
  • 99 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-1.5%) to 78.355%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/state/cluster.go 0 1 0.0%
pkg/controllers/provisioning/provisioner.go 28 34 82.35%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/existingnode.go 2 94.12%
pkg/controllers/state/cluster.go 2 83.52%
pkg/operator/controller/typed.go 2 93.55%
pkg/controllers/provisioning/controller.go 13 25.93%
pkg/controllers/provisioning/batcher.go 19 16.67%
pkg/controllers/provisioning/provisioner.go 27 76.63%
pkg/scheduling/hostportusage.go 34 45.95%
Totals Coverage Status
Change from base Build 4068914371: -1.5%
Covered Lines: 6219
Relevant Lines: 7937

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the alter-bindings-tracking branch from d7bddc6 to 5a061d1 Compare February 1, 2023 22:15
@jonathan-innis
Copy link
Member Author

Good feedback @ellistarn

ellistarn
ellistarn previously approved these changes Feb 1, 2023
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 1, 2023 22:44
@jonathan-innis jonathan-innis merged commit 9766dd1 into kubernetes-sigs:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants