fix!: Prevent eviction hanging due to do-not-evict
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
changed the title
do-not-evict
Pull Request Test Coverage Report for Build 4245924130
💛 - Coveralls |
|
Do we need a breaking notice on this? |
jonathan-innis
changed the title
do-not-evictdo-not-evict
jonathan-innis
changed the title
do-not-evictdo-not-evict
njtran
reviewed
Feb 22, 2023
Docs will go in the main |
jonathan-innis
force-pushed
the
do-not-evict-hanging
branch
from
218647c to
b37e3ef
Compare
jonathan-innis
force-pushed
the
do-not-evict-hanging
branch
from
b37e3ef to
1096a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/karpenter-provider-aws#3383
Description
Remove
do-not-evictpreventing eviction when the Node is forcefully deleted throughkubectl delete nodeor some other forceful deletion mechanism (like AWS interruption).do-not-evictshould only be considered for Karpenter's voluntary disruption mechanisms (like emptiness/underutilization/consolidation, expiration, drift, etc.)BREAKING CHANGE: Customers who are currently deleting nodes with pods that have
do-not-evictannotations will no longer have nodes hang on draining for this, meaning that they can't usedo-not-evictas a stop-gapHow was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.