chore!: Remove container loglevel from config-logging
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
remove-container-loglevel
branch
from
8053d29 to
25670f0
Compare
jonathan-innis
force-pushed
the
remove-container-loglevel
branch
from
25670f0 to
b54bdfe
Compare
Pull Request Test Coverage Report for Build 4660025705
💛 - Coveralls |
ellistarn
reviewed
Apr 10, 2023
It swallows the value if it's set but isn't utilized. This should be effectively a minimally breaking-change for customers |
jonathan-innis
changed the title
config-loggingconfig-logging
ellistarn
approved these changes
Apr 10, 2023
jonathan-innis
added a commit
that referenced
this pull request
Apr 10, 2023
This reverts commit 58087ae.
jonathan-innis
added a commit
that referenced
this pull request
Apr 10, 2023
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Container-based log level should not be supported since the separate containers for the controller and the webhook were removed in #29. These values should be removed from the
values.yamlfile in the helm chartBREAKING: A user who would normally set the logLevel through
--set controller.logLevelwill now have to set it globally; otherwise, the log level will default to the global levelHow was this change tested?
make presubmitmake applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.