Issue with install.sh: Could not find glibc and Manual Installation Steps

[hjm79]

Checks

• I ran q doctor in the affected command line session and it didn't resolve my issue
• I ran q restart and it didn't resolve my issue
• I searched the discussions in this repo and there are no duplicates of my issue

Expected behaviour

I encountered an issue while trying to install the Amazon Q CLI on my Ubuntu 22.04 system using the provided install.sh script. The installation failed due to a glibc version compatibility issue. Below are the details of the error and the steps I took to manually install the CLI.

Error Message:
[ERROR] Could not find glibc.
[ERROR] This release built for a GNU system with glibc 2.34 or newer, try installing the musl version of the CLI.

Actual behaviour

Steps Taken:

Attempted Installation Using install.sh:

Ran the install.sh script, which failed with the above error.
The script could not locate the glibc version, even though my system meets the requirement (glibc 2.35).
Manual Installation:

Downloaded the Amazon Q CLI zip file.
Extracted the files and manually copied the q and qterm binaries to the /bin directory.
Updated my .zshrc file to include the necessary pre and post integration blocks:

Amazon Q pre block. Keep at the top of this file.

[[ -f "${HOME}/.local/share/amazon-q/shell/zshrc.pre.zsh" ]] && builtin source "${HOME}/.local/share/amazon-q/shell/zshrc.pre.zsh"
export Q_TERM="qterm"

Amazon Q post block. Keep at the bottom of this file.

[[ -f "${HOME}/.local/share/amazon-q/shell/zshrc.post.zsh" ]] && builtin source "${HOME}/.local/share/amazon-q/shell/zshrc.post.zsh"

Restarted the terminal and manually started qterm.

Current Issue:

Despite setting everything up, running q doctor still indicates that qterm is not running or that the terminal is not using the latest integration.
Terminal output:

✘ Amazon Q terminal integrations: qterm is not running in this terminal, please try restarting your terminal

Q_TERM=qterm

Could you please provide guidance on how to resolve this issue? I suspect it might be related to the initial glibc detection failure. Is there a recommended workaround for this?

Thank you for your assistance.

Steps to reproduce

No response

Environment

[q-details]
version = "1.4.0"
hash = "a1635029720bc46c285f004832dda2c89b9b9204"
date = "2024-08-28T20:38:27.489062Z (7d ago)"

[system-info]
chip = "Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz"
total-cores = 4
memory = "23.19 GB"

[system-info.os.linux]
kernel_version = "5.15.0-119-generic"
id = "ubuntu"
name = "Ubuntu"
pretty_name = "Ubuntu 22.04.4 LTS"
version_id = "22.04"
version = "22.04.4 LTS (Jammy Jellyfish)"

[environment]
cwd = "/home/USER"
cli-path = "/home/USER/.local/bin/q"
shell-path = "/usr/bin/zsh"
shell-version = "5.8"
install-method = "unknown"
in-ssh = true

[env-vars]
PATH = "/home/USER/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/USER/.local/bin"
Q_SET_PARENT_CHECK = "1"
Q_TERM = "qterm"
SHELL = "/usr/bin/zsh"
TERM = "xterm-256color"
XDG_SESSION_TYPE = "tty"

[ohmantics]

I get this same error on Ubuntu 23.10 on AArch64 (Raspberry Pi 4 Model B Rev 1.4). Running the q binary directly from the install folder triggers an illegal instruction trap. Fig worked just fine before.

Also getting this error with Debian 11 (bullseye) on x86_64 in an LXC container on top of Proxmox.

[laithalsaadoon]

I made a few changes to install.sh and got it working on Ubuntu 22.04 on WSL2 (Windows 11)

...
check_glibc_version() {
    if [ -f /lib64/libc.so.6 ]; then
        LIBC_PATH=/lib64/libc.so.6
    elif [ -f /lib/libc.so.6 ]; then
        LIBC_PATH=/lib/libc.so.6
   # added this elif based on where libc.so.6 is in ubuntu
    elif [ -f /lib/x86_64-linux-gnu/libc.so.6 ]; then
        LIBC_PATH=/lib/x86_64-linux-gnu/libc.so.6
    else
        log_error "Could not find glibc."
        return 1
    fi

# update the sed parsing to correctly get the glibc version
    glibc_version=$("$LIBC_PATH" | sed -n 's/^GNU C Library .* stable release version \([0-9]*\)\.\([0-9]*\).*$/\1.\2/p')

[hjm79]

thank you

[brc-dd]

on aarch64, the path will be /lib/aarch64-linux-gnu/libc.so.6 (you can run find /lib/ | grep libc.so.6, but you might have multiple glibc versions, so choose the one that matches your host and program architecture)

I think the maintainers can hardcode aarch64-linux-gnu or x86_64-linux-gnu depending on the installer that's downloaded?

Or probably they can use ldd too, but I'm not sure how cross-platform that is:

check_glibc_version() {
    LIBC_PATH=$(ldd "$SCRIPT_DIR/bin/q" | grep libc | awk '{print $3}')
    if [ -z "$LIBC_PATH" ]; then
        log_error "Could not find glibc."
        return 1
    fi

    LIBC_VERSION=$("$LIBC_PATH" --version 2>/dev/null | head -n 1)
    if [ -z "$LIBC_VERSION" ]; then
        log_error "Could not determine glibc version."
        return 1
    fi

    if [[ "$LIBC_VERSION" =~ ([0-9]+)\.([0-9]+) ]]; then
        major="${BASH_REMATCH[1]}"
        minor="${BASH_REMATCH[2]}"
    else
        log_error "Could not parse glibc version."
        return 1
    fi

    if [ -z "$minor" ]; then
        minor=0
    fi

    if [ "$major" -gt 2 ] || { [ "$major" -eq 2 ] && [ "$minor" -ge 34 ]; }; then
        return 0
    else
        return 1
    fi
}