fix: add coverage for all ticket formats #4997
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #4965
Description of changes:
There are two changes in this PR:
Remove the manual setting of session ticket formats in
s2n_deserialize_resumption_state_test.c. We no longer make assumptions about the possible format versionsUpdate the path to coverage reports in
ReadmeCall-outs:
N/A
Testing:
Generated fuzz coverage reports locally and confirmed that
S2N_SERIALIZED_FORMAT_TLS12_V3is coveredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.