-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS::Serverless::SimpleTable Auto-Scaling #377
Comments
This is beautiful! Thanks for the detailed proposal showing SAM template and associated CFN template. A few things I would encourage you to think:
|
Are you thinking of an optional role to override the generated one? If so, then that may be an option.
Do we need to? No, the console doesn't even let you choose this. Could we? Sure, do you want to?
¯_(ツ)_/¯ I guess it's entirely possible for dynamo to add more metrics that you might want to scale based off of, but I think that allowing the user to specify their own e.g. ReadScaling: (optional, disabled if omitted)
MinCapacity: Integer (default: 5, same as console)
MaxCapacity: Integer (default: 4000, same as console)
TargetUtilization: Integer (default: 70, same as console, must be undefined if OtherScalingMetric is defined)
OtherScalingMetric: Integer (optional, must be undefined if TargetUtilization is defined) I've seen this sort of conditional configuration in other areas of SAM, like the |
+1 |
I was playing with translator implementing the same feature. I'm currently stuck with an error that I can't figure out, let me know if I can help. |
+1 |
Just to point out, |
Any update on this? It would be really handy to have something like the proposed in here. |
#705 (in the upcoming v1.10.0 release) changed |
I would suggest that this issue be reopened as the on-demand capacity mode is expensive and not a one-size-fits-all solution of the aforementioned problem. |
DynamoDB Auto-Scaling via CFN is verbose to say the least. I propose that we add configuration properties to
AWS::Serverless::SimpleTable
which will implicitly generate all the necessary resources via the SAM translator.SAM Template:
Translated CFN Template:
I welcome any discussion on this proposal. This proposed implementation would generate a scaling role per table, which would be wasteful. The console creates and reuses a single role for this purpose, but this may be awkward to implement in SAM.
I would be willing to work on this once I become more familiar with the internals of the SAM translator, but it may best be left to someone with more intimate knowledge.
The text was updated successfully, but these errors were encountered: