Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry metric middleware probably shouldn't return error if no retry metadata #163

Closed
jasdel opened this issue Sep 2, 2020 · 1 comment
Closed

Retry metric middleware probably shouldn't return error if no retry metadata #163

jasdel opened this issue Sep 2, 2020 · 1 comment
Labels
bug This issue is a bug.
Milestone
v1.0 Release Cand...

Comments

@jasdel
Copy link
Contributor

jasdel commented Sep 2, 2020 •
edited
Loading

The retry metric middleware will return an error if it cannot find the retry metadata in the middleware context. This middleware should most likely just forward on the request instead of errorring out.

https://github.com/aws/aws-sdk-go-v2/blob/223893cb4d9d2da39d7f82d87a8614f0f8c95bbe/aws/retry/middleware.go#L132-L135
@jasdel jasdel added the bug This issue is a bug. label Sep 2, 2020
@jasdel jasdel added this to the v1.0 Release Candidate milestone Nov 13, 2020
@jasdel jasdel mentioned this issue Dec 7, 2020
Closed
@jasdel
Copy link
Contributor Author

jasdel commented Dec 7, 2020

created in v2 SDK repo.

@jasdel jasdel closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
v1.0 Release Candidate
Development

No branches or pull requests
1 participant
@jasdel