Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Create test utilities to ease writing tests for batch processor #1363

Closed
1 of 2 tasks
Tracked by #1009
heitorlessa opened this issue Jul 25, 2022 · 2 comments
Closed
1 of 2 tasks
Tracked by #1009
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

Batch Processor tests require test data factories with successful and failure data (poison pills). The process to setup, arrange, and assert can be greatly simplified.

In the future, we should remove tests containing the legacy processor (PartialSQSProcessor) too.

Why is this needed?

Reduce operational overhead and cognitive load in writing tests for Batch Processor involving data in mixed forms.

Which area does this relate to?

Batch processing

Solution

No response

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jul 25, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 8, 2022
@heitorlessa
Copy link
Contributor Author

done in v2

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

1 participant