Adding deploy mode for datasets #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Usually you need to deploy not a single dataset but many, so to have a single parameters-$ENV.json file per environment forces you to change the json descriptor each time you need to deploy a new dataset, losing the Jsons that were used to deploy the above datasets.
In the day to day work with the framework, it is common the need to re-deploy the same dataset several times, after a minor change, specially in the dev environment, and rewrite the Json descriptor file each time is not an optimal way to do that.
Instead of having a single json, the present alternative propose to have a folder with one Json file per dataset.
That way the template creates the necessary resources for each dataset from the parameters defined in a parameters/parameters-$DATASET.json file in the parameters folder, the dataset will be deployed only if it has changed since the last commit, that way we have in the parameters folder the history of all the deployed datasets.
The resources will be created depending on the branch (dev, test, master) in the corresponding environment/account (dev,test,prod), so no specific environment is necessary in the parameters file name itself.