Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-s3-stepfunctions): Replace EventBridge enabled property override with prop #565

Closed
2 tasks
mickychetta opened this issue Jan 10, 2022 · 2 comments · Fixed by #666
Closed
2 tasks

feat(aws-s3-stepfunctions): Replace EventBridge enabled property override with prop #565

mickychetta opened this issue Jan 10, 2022 · 2 comments · Fixed by #666
Assignees
@mickychetta
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@mickychetta
Copy link
Contributor

mickychetta commented Jan 10, 2022 •
edited by biffgaut
Loading

The S3 cfnBucket class has created new prop called eventBridgeEnabled in S3 bucket props. We will replace the override code line

cfnBucket.addPropertyOverride('NotificationConfiguration.EventBridgeConfiguration.EventBridgeEnabled', true);

with the newly added prop to properly create new S3 buckets with EventBridge enabled.

Use Case

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@mickychetta mickychetta added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Jan 10, 2022
@mickychetta mickychetta self-assigned this Jan 10, 2022
@biffgaut
Copy link
Contributor

Clarify - this is to update the CDK. We've already implemented in our code using the escape hatch. To do this in the CDK will help them and simplify our code.

@biffgaut biffgaut closed this as completed Mar 1, 2022
@biffgaut biffgaut reopened this Mar 1, 2022
@mickychetta
Copy link
Contributor Author

Issue:
aws/aws-cdk#18076

Related PRs:
aws/aws-cdk#18150
aws/aws-cdk#18614

@mickychetta mickychetta mentioned this issue Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mickychetta mickychetta

Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Milestone
No milestone
2 participants
@mickychetta @biffgaut