fix(cli): unable to import types with all-caps TLAs #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsii requires that class names will not be all-caps. This means that a class name like `VPC` is not allowed. To address this, we convert all TLAs to pascal case (i.e. `Vpc`). Add a unit test for type name normalization. Fixes #209
added 2 commits
May 26, 2020 23:13
iliapolo
previously approved these changes
May 27, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
iliapolo
approved these changes
May 27, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii requires that class names will not be all-caps. This means that a class name like
VPCis not allowed. To address this, we convert all TLAs to pascal case (i.e.Vpc).Add a unit test for type name normalization.
Fixes #209
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license