feat(cli): import constructs for all API levels #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following this change, when using `cdk8s import` to generate constructs from schemas, the CLI will generate constructs for all API levels and not just the latest stable version. The name of the generated class will now include the API level, unless this is a `v1` resource. For example, `v1/Pod` will be called `Pod`, while `v1beta1/Ingress` will be called `IngressV1Beta1`. This change only applies to `cdk8s import k8s` and does not apply when importing CRDs, in which case a single CRD always includes a single resource definition. BREAKING CHANGE: when importing k8s api objects using `cdk8s import`, non-stable APIs will be have an API level postfix. For example, [email protected] will have an `IngressV1Beta1` API object.
iliapolo
requested changes
Nov 17, 2020
iliapolo
approved these changes
Nov 17, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this change, when using
cdk8s importto generate constructs from schemas, the CLI will generate constructs for all API levels and not just the latest stable version.The name of the generated class will now include the API level, unless this is a
v1resource. For example,v1/Podwill be calledPod, whilev1beta1/Ingresswill be calledIngressV1Beta1.This change only applies to
cdk8s import k8sand does not apply when importing CRDs, in which case a single CRD always includes a single resource definition.BREAKING CHANGE: when importing k8s api objects using
cdk8s import, non-stable APIs will be have an API level postfix. For example, [email protected] will have anIngressV1Beta1API object.--includeCLI option has been removed since all API objects are always imported.Resolves #380
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license