Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests parameters not available in SDKs or cache keys #163

Closed
jamesls opened this issue Nov 10, 2016 · 0 comments · Fixed by #164
Closed

requests parameters not available in SDKs or cache keys #163

jamesls opened this issue Nov 10, 2016 · 0 comments · Fixed by #164
Labels

Comments

@jamesls
Copy link
Member

jamesls commented Nov 10, 2016

Consider this route:

@app.route('/users/{user}')
def users(): pass

When we create the method request, we're not actually specifying the "user" value as a requestParameter.

The API will still work as expected, however, there's a few features that can't be leveraged unless we specify them including:

  • The generated javascript SDK won't include the "user" as a parameter. Instead it will render a path for /users.
  • The "user" parameter isn't available as part of the cache key when caching is enabled.

Neither of these matter yet for chalice because these features aren't exposed, but I'd like to add support for these so I'll need to get this updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant