Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: update IG validation to reject reference params with no target #123

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

ssvegaraju
Copy link
Contributor

Issue #, if available:
#449
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carvantes
Copy link
Contributor

Also, the error msg of Error: The following input is not a search parameter: {...} is not that helpful. The isFhirSearchParam is a very basic check to make sure that required fields are present and that the field types are correct.

Maybe we can create a separate method for semantic validations like this that throws more specific error messages.

@ssvegaraju ssvegaraju merged commit f789799 into mainline Sep 23, 2021
@ssvegaraju ssvegaraju deleted the fix-IGReferenceSearchParam branch September 23, 2021 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants