This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: accept Elasticsearch client as optional constructor argument #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow passing ElasticSearch client instance
justinusmenzel
commented
May 20, 2021
src/elasticSearchService.ts
Outdated
| @@ -155,7 +161,8 @@ export class ElasticSearchService implements Search { | |||
| // eslint-disable-next-line class-methods-use-this | |||
| private async executeQuery(searchQuery: any): Promise<{ hits: any[]; total: number }> { | |||
| try { | |||
| const apiResponse = await ElasticSearch.search(searchQuery); | |||
| console.log(`Query: ${JSON.stringify(searchQuery, null, 2)}`); | |||
There was a problem hiding this comment.
Oh no, that's nice for debugging but wasn't intended in the MR.
carvantes
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
To support testing against a local ElasticSearch instance allow passing a Client instance to the ElasticSearchService constructor.
Should not be a breaking change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.