Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: handle searches against static ES mapping #85

Merged
merged 6 commits into from
Jun 28, 2021
Merged

feat: handle searches against static ES mapping #85

merged 6 commits into from
Jun 28, 2021

Conversation

rsmayda
Copy link
Contributor

@rsmayda rsmayda commented Jun 28, 2021

Description of changes:

  • Adding new constructor parameter to pass-in if customer is using static mapping or not
    • if true .keyword will be added to the restricted search queries

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsmayda rsmayda added the enhancement New feature or request label Jun 28, 2021
@rsmayda rsmayda requested a review from carvantes June 28, 2021 20:36
@rsmayda rsmayda self-assigned this Jun 28, 2021
src/QueryBuilder/typeQueries/tokenQuery.test.ts Outdated Show resolved Hide resolved
src/elasticSearchService.ts Outdated Show resolved Hide resolved
@rsmayda rsmayda requested a review from carvantes June 28, 2021 21:55
Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good. But unit tests are failing.

src/elasticSearchService.ts Outdated Show resolved Hide resolved
Co-authored-by: Nestor Carvantes <[email protected]>
@rsmayda rsmayda merged commit f70045b into v2.x.x Jun 28, 2021
@rsmayda rsmayda deleted the ref-keys branch June 28, 2021 22:26
rsmayda added a commit that referenced this pull request Jul 1, 2021
* feat: Add flexibility to searches against static ES mapping (#85)

* feat: handle uris; not escaping the value (#86)

* feat: do not escape uri parameters

* feat: handle uris; not escaping the value

* chore: update snapshot for alias

* Update src/QueryBuilder/typeQueries/uriQuery.test.ts

Co-authored-by: Nestor Carvantes <[email protected]>

Co-authored-by: Nestor Carvantes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants