This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
feat: handle searches against static ES mapping #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvantes
suggested changes
Jun 28, 2021
carvantes
reviewed
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes look good. But unit tests are failing.
carvantes
approved these changes
Jun 28, 2021
Co-authored-by: Nestor Carvantes <[email protected]>
rsmayda
added a commit
that referenced
this pull request
Jul 1, 2021
rsmayda
added a commit
that referenced
this pull request
Jul 1, 2021
* feat: Add flexibility to searches against static ES mapping (#85) * feat: handle uris; not escaping the value (#86) * feat: do not escape uri parameters * feat: handle uris; not escaping the value * chore: update snapshot for alias * Update src/QueryBuilder/typeQueries/uriQuery.test.ts Co-authored-by: Nestor Carvantes <[email protected]> Co-authored-by: Nestor Carvantes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
true
.keyword
will be added to the restricted search queriesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.