Make streaming blobs required/default #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Apr 28, 2022
smithy-model/src/test/java/software/amazon/smithy/model/loader/ModelUpgraderTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/loader/ModelUpgraderTest.java
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
http-payload-req-def
branch
2 times, most recently
from
1813209 to
44b73a0
Compare
kstich
requested changes
May 2, 2022
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelUpgrader.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelUpgrader.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/software/amazon/smithy/model/validation/validators/HttpPayloadValidator.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/software/amazon/smithy/model/validation/validators/HttpPayloadValidator.java
Outdated
Show resolved
Hide resolved
.../src/test/resources/software/amazon/smithy/cli/commands/upgrade/cases/http-payload.v1.smithy
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
http-payload-req-def
branch
2 times, most recently
from
2c5cfce to
77b7f7a
Compare
JordonPhillips
force-pushed
the
http-payload-req-def
branch
from
77b7f7a to
e5f59f0
Compare
JordonPhillips
force-pushed
the
http-payload-req-def
branch
from
e5f59f0 to
d12ee97
Compare
JordonPhillips
changed the title
kstich
approved these changes
May 12, 2022
mtdowling
reviewed
May 13, 2022
mtdowling
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming blobs have always had an implicit default value, and this pr makes that status explicit by requiring that such members have either the required or the default trait.
1.0 models will have the default trait applied automatically, but it must be explicitly added in 2.0 models.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.