Add resource properties structure and validation #1213

DavidOgunsAWS · 2022-05-04T07:23:31Z

Description of changes:
Adds resource properties structure, new traits, and new validation.

This PR is a combination of the following:

Add AWS resource tag modeling to Smithy #1272 (resource tagging changes)
Resource properties specification documentation #1246 (Specification documentation for resource properties)
Add design document for resource properties addition to IDL 2.0 #1245 (Design doc for resource properties)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

VERSION

smithy-model/src/main/java/software/amazon/smithy/model/knowledge/MemberPropertyIndex.java

...oftware/amazon/smithy/model/validation/validators/ResourceOperationInputOutputValidator.java

smithy-model/src/main/java/software/amazon/smithy/model/traits/PropertyTrait.java

...-model/src/main/java/software/amazon/smithy/model/validation/testrunner/SmithyTestSuite.java

smithy-model/src/test/java/software/amazon/smithy/model/ErrorsFileTest.java

smithy-model/src/main/java/software/amazon/smithy/model/knowledge/OperationIndex.java

smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PropertyBindingIndex.java

mtdowling

Didn't finish a full reiew yet, but publishing comments for smithy-model and json schema now.

docs/source/1.0/spec/core/idl.rst

docs/source/1.0/spec/core/traits.rst

smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PropertyBindingIndex.java

...ain/java/software/amazon/smithy/model/validation/validators/ResourceIdentifierValidator.java

...resources/software/amazon/smithy/aws/traits/errorfiles/tagging/valid-tag-service-wide.smithy

...test/resources/software/amazon/smithy/aws/traits/errorfiles/tagging/invalid-tag-types.errors

...smithy/aws/traits/errorfiles/tagging/invalid-tag-enabled-service-no-taggable-resource.errors

.../src/main/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConverter.java

...dformation/src/main/java/software/amazon/smithy/aws/cloudformation/schema/model/Tagging.java

smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/TaggableTrait.java

smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java

...-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/ServiceTaggingValidator.java

smithy-aws-traits/src/main/resources/META-INF/smithy/aws.api.smithy

smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java

mtdowling

~~Is member elision syntax for resource properties and the for modifier for structures to lexically bind structure member elision to a resource documented anywhere?~~

Ah, yes, it was preemptively documented when it was added.

docs/source/1.0/spec/core/model.rst

docs/source/1.0/spec/core/traits.rst

docs/source/1.0/spec/core/model.rst

designs/resource-properties.md

mtdowling · 2022-07-23T03:07:45Z

Looks like we need to update the IDL parser too so that it can use type elision with resource properties: https://github.com/awslabs/smithy/blob/idl-2.0/smithy-model/src/main/java/software/amazon/smithy/model/loader/SetResourceBasedTargets.java#L74

docs/source-1.0/spec/core/resource-traits.rst

docs/source-1.0/spec/core/model.rst

docs/source-2.0/quickstart.rst

docs/source-2.0/spec/service-types.rst

...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/TaggableApiConfig.java

...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/TaggingShapeUtils.java

smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java

smithy-aws-traits/src/main/resources/META-INF/smithy/aws.api.smithy

Co-authored-by: Michael Dowling <[email protected]>

…oader/invalid/properties-v2-only.smithy Co-authored-by: Michael Dowling <[email protected]>

...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/TaggableApiConfig.java

…ead code.

mtdowling

Let's squash these intermediate commits before merging

* Resource properties and AWS tagging traits (unstable) and validation added. CfnConverter updated. Co-authored-by: Michael Dowling <[email protected]>

DavidOgunsAWS requested a review from a team as a code owner May 4, 2022 07:23

DavidOgunsAWS changed the title ~~Add resource properties definiteion~~ Add resource properties structure and validation May 4, 2022

DavidOgunsAWS mentioned this pull request May 5, 2022

Resource property and related traits validation and tests #1185

Closed

mtdowling requested changes May 13, 2022

View reviewed changes

DavidOgunsAWS mentioned this pull request Jun 1, 2022

Resource properties specification documentation #1246

Closed

kstich requested changes Jun 15, 2022

View reviewed changes

mtdowling force-pushed the idl-2.0 branch from c37324a to bd976bb Compare June 24, 2022 16:56

DavidOgunsAWS force-pushed the properties branch from c217fa0 to ac44fff Compare July 5, 2022 19:52

mtdowling requested changes Jul 15, 2022

View reviewed changes

mtdowling reviewed Jul 15, 2022

View reviewed changes

smithy-aws-traits/src/main/resources/META-INF/smithy/aws.api.smithy Outdated Show resolved Hide resolved

mtdowling reviewed Jul 18, 2022

View reviewed changes

smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/AwsTagIndex.java Show resolved Hide resolved

mtdowling requested changes Jul 19, 2022

View reviewed changes

mtdowling reviewed Jul 19, 2022

View reviewed changes

designs/resource-properties.md Show resolved Hide resolved

mtdowling reviewed Jul 19, 2022

View reviewed changes

designs/resource-properties.md Show resolved Hide resolved

DavidOgunsAWS force-pushed the properties branch from c1a9ea9 to 75e323d Compare July 26, 2022 01:05

Resource properties and tagging added. CfnConverter updated.

5269dd5

DavidOgunsAWS force-pushed the properties branch from 75e323d to 5269dd5 Compare July 26, 2022 23:38

Updated docs to add new taggable and tagEnabled traits.

c704881

mtdowling requested changes Jul 27, 2022

View reviewed changes

DavidOgunsAWS and others added 9 commits July 27, 2022 17:48

Removed unused method.

64654c9

Update docs/source-2.0/spec/service-types.rst

4dd8ef6

Co-authored-by: Michael Dowling <[email protected]>

Update docs/source-2.0/spec/service-types.rst

a9a3587

Co-authored-by: Michael Dowling <[email protected]>

PR comments.

cbc1cc4

PR comments.

72ca17e

Update docs/source-2.0/spec/resource-traits.rst

b4d8f14

Co-authored-by: Michael Dowling <[email protected]>

PR comments.

2736ddd

Merge branch 'properties' of github.com:awslabs/smithy into properties

8157875

Update docs/source-2.0/aws/aws-core.rst

1e3a070

Co-authored-by: Michael Dowling <[email protected]>

DavidOgunsAWS and others added 9 commits July 29, 2022 16:37

Update smithy-model/src/test/resources/software/amazon/smithy/model/l…

0030a12

…oader/invalid/properties-v2-only.smithy Co-authored-by: Michael Dowling <[email protected]>

PR comment

2ab6203

Merge branch 'properties' of github.com:awslabs/smithy into properties

0bcc00c

PR comments.

b1be4bc

Fix AST model loader not failing to load resources properties from V1.

93ed966

PR comments

89ad8bd

Modify validation error message

09774bb

PR comments.

04624e6

PR comments

e29d4df

mtdowling requested changes Aug 2, 2022

View reviewed changes

...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/TaggableApiConfig.java Outdated Show resolved Hide resolved

...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/tagging/TaggableApiConfig.java Show resolved Hide resolved

DavidOgunsAWS added 2 commits August 2, 2022 11:42

Adjustments to docs.

fc8b3a5

PR comments, and test coverage for validation event output. Removed d…

638436e

…ead code.

mtdowling approved these changes Aug 2, 2022

View reviewed changes

DavidOgunsAWS merged commit f3dc2d1 into idl-2.0 Aug 2, 2022

mtdowling added a commit that referenced this pull request Aug 10, 2022

Add resource properties structure and validation (#1213)

2f956a7

* Resource properties and AWS tagging traits (unstable) and validation added. CfnConverter updated. Co-authored-by: Michael Dowling <[email protected]>

mtdowling deleted the properties branch August 10, 2022 17:25

mtdowling added a commit that referenced this pull request Aug 10, 2022

Add resource properties structure and validation (#1213)

c8e8ae3

* Resource properties and AWS tagging traits (unstable) and validation added. CfnConverter updated. Co-authored-by: Michael Dowling <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add resource properties structure and validation #1213

Add resource properties structure and validation #1213

DavidOgunsAWS commented May 4, 2022 •

edited

Loading

mtdowling left a comment

mtdowling left a comment •

edited

Loading

mtdowling commented Jul 23, 2022

mtdowling left a comment

Add resource properties structure and validation #1213

Add resource properties structure and validation #1213

Conversation

DavidOgunsAWS commented May 4, 2022 • edited Loading

mtdowling left a comment

Choose a reason for hiding this comment

mtdowling left a comment • edited Loading

Choose a reason for hiding this comment

mtdowling commented Jul 23, 2022

mtdowling left a comment

Choose a reason for hiding this comment

DavidOgunsAWS commented May 4, 2022 •

edited

Loading

mtdowling left a comment •

edited

Loading