Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move useIntegerType to jsonschema #1495

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

JordonPhillips
Copy link
Contributor

The integer type is a sort of vaugely supported thing in json schema, not jsut OpenAPI. So this moves that configuration up to the generic settings so it can also be applied to cloudformation and any future derivative tooling.

The int32 / int64 formats were kept to openapi since that isn't referenced in the the json schema spec.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The integer type is a sort of vaugely supported thing in json schema,
not jsut OpenAPI. So this moves that configuration up to the generic
settings so it can also be applied to cloudformation and any future
derivative tooling.

The int32 / int64 formats were kept to openapi since that *isn't*
referenced in the the json schema spec.
@JordonPhillips JordonPhillips requested a review from a team as a code owner November 14, 2022 18:16
@JordonPhillips JordonPhillips merged commit 33fe7b1 into smithy-lang:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants