Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smithy code generation guide #1592

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add Smithy code generation guide #1592

merged 1 commit into from
Jan 30, 2023

Conversation

mtdowling
Copy link
Member

Also adds the start of a glossary.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mtdowling mtdowling requested a review from a team as a code owner January 26, 2023 05:45
Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only through the glossary page so far.

docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
docs/source-2.0/glossary.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core documents could use a pass that adds linking to the glossary.

docs/source-2.0/guides/codegen/creating-codegen-repo.rst Outdated Show resolved Hide resolved
docs/source-2.0/guides/codegen/creating-codegen-repo.rst Outdated Show resolved Hide resolved
@mtdowling
Copy link
Member Author

After this is all reviewed, I'll move the docs to a more specific folder name than codegen.

docs/source-2.0/guides/codegen/index.rst Outdated Show resolved Hide resolved
docs/source-2.0/guides/codegen/index.rst Outdated Show resolved Hide resolved
docs/source-2.0/guides/codegen/index.rst Outdated Show resolved Hide resolved
@mtdowling mtdowling force-pushed the creating-a-generator branch from 78a5c48 to 18fb7bb Compare January 30, 2023 22:13
@mtdowling mtdowling requested a review from kstich January 30, 2023 22:14
@mtdowling mtdowling force-pushed the creating-a-generator branch from 18fb7bb to 02bf313 Compare January 30, 2023 22:17
@mtdowling mtdowling force-pushed the creating-a-generator branch from 02bf313 to bd7c91b Compare January 30, 2023 22:33
@mtdowling mtdowling merged commit 9ae748c into main Jan 30, 2023
@mtdowling mtdowling deleted the creating-a-generator branch March 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants