Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OR condition in scoped attribute selector #1618

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fix OR condition in scoped attribute selector #1618

merged 1 commit into from
Feb 16, 2023

Conversation

AndrewFossAWS
Copy link
Contributor

@AndrewFossAWS AndrewFossAWS commented Feb 15, 2023 •
edited
Loading

Issue #, if available:
A bug was discovered when using , (OR condition) in scoped attribute selector

enum Suit {
    DIAMOND = "diamond"
    CLUB = "club"
    HEART = "heart"
    SPADE = "spade"
}

enum Color {
    RED
    BLACK
}

[@trait|enum|(values): @{name} ^= DIA, BLA] (return enums with names starting with DIA or BLA

Expected: smithy.example#Suit, smithy.example#Color

Acutal: smithy.example#Suit

Description of changes:
Fix OR condition in scoped attribute selector

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndrewFossAWS AndrewFossAWS requested a review from a team as a code owner February 15, 2023 20:14
@AndrewFossAWS AndrewFossAWS merged commit 0a8a8f6 into smithy-lang:main Feb 16, 2023
@AndrewFossAWS AndrewFossAWS deleted the scopedattr branch September 21, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtdowling mtdowling mtdowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewFossAWS @mtdowling