Improve operation and trait grammar #1800
Merged
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operation statements now have an OperationProperty grammar that makes parsing operations easier since it makes each "member" of the operation and single named rule rather than multiple rules. Trait parsing is improved to better handle WS and reuse NodeObjectKvp.
mtdowling
added a commit
that referenced
this pull request
Jun 1, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
JordonPhillips
approved these changes
Jun 2, 2023
mtdowling
added a commit
that referenced
this pull request
Jun 2, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
mtdowling
added a commit
that referenced
this pull request
Jun 2, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
mtdowling
added a commit
that referenced
this pull request
Jun 2, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
mtdowling
added a commit
that referenced
this pull request
Jun 8, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
mtdowling
added a commit
that referenced
this pull request
Jun 16, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
mtdowling
added a commit
that referenced
this pull request
Jun 19, 2023
This change implements the updated grammar for traits and operations in #1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
This change implements the updated grammar for traits and operations in smithy-lang#1800. WS and BR handling is now more explicit, including individual token trees for comments, spaces, and commas. NODE_OBJECT_KEY now contains an IDENTIFIER and QUOTED_TEXT tree rather than raw tokens. This change also cleans up token trees and adds some new features: * They implement FromSourceLocation * Removed unused methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operation statements now have an OperationProperty grammar that makes parsing operations easier since it makes each "member" of the operation and single named rule rather than multiple rules.
Trait parsing is improved to better handle WS and reuse NodeObjectKvp.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.